Skip to content

op-chain-ops: remove L1 clique option#12977

Merged
protolambda merged 1 commit intodevelopfrom
rm-clique
Nov 19, 2024
Merged

op-chain-ops: remove L1 clique option#12977
protolambda merged 1 commit intodevelopfrom
rm-clique

Conversation

@protolambda
Copy link
Contributor

Description

This PR removes the L1 clique configuration option from the op-chain-ops deploy config / tooling.

Our L1 contracts assume Shanghai is active, which assumes merge is active, which has an extra-data limit of 32 bytes, which conflicts with Clique. It's really just legacy code that we can remove.

This supersedes #12557

Tests

Removes dead code

Additional context

I tried to attribute author info, but the author of the commits appears as:

commit 7e0f148cd56108aa8dfafe033c02b22b9b7a8d53 (HEAD)
Author: = <=>
Date:   Mon Oct 21 23:44:57 2024 +0100

And I don't have permission to push to the branch that the PR was opened with (develop, not a proper feature branch).

Metadata

Fix #12518

@tynes tynes added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@protolambda protolambda added this pull request to the merge queue Nov 19, 2024
Merged via the queue into develop with commit b824f9b Nov 19, 2024
@protolambda protolambda deleted the rm-clique branch November 19, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-chain-ops: Cleanup L1 Genesis Generation

2 participants