op-chain-ops: remove L1 clique option#12977
Merged
protolambda merged 1 commit intodevelopfrom Nov 19, 2024
Merged
Conversation
tynes
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the L1 clique configuration option from the op-chain-ops deploy config / tooling.
Our L1 contracts assume Shanghai is active, which assumes merge is active, which has an extra-data limit of 32 bytes, which conflicts with Clique. It's really just legacy code that we can remove.
This supersedes #12557
Tests
Removes dead code
Additional context
I tried to attribute author info, but the author of the commits appears as:
And I don't have permission to push to the branch that the PR was opened with (
develop, not a proper feature branch).Metadata
Fix #12518